New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sublime-merge: askpass bug fix #90685
Conversation
Replace ssh-askpass-sublime executable from sublime-merge that is incompatable with the nix package wrapper. Fixes NixOS#88600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final nitpick and then it's good to merge, could you change the commit message for the version bump to:
sublime-merge: 2011 -> 2022
Absolutely, though is there a preferred way to indicate that it's just the dev version that's updating, not the stable version? Or does it not matter? |
Since
Sorry for messing up the example message. |
Got it, that makes sense, I've updated the commit message! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for making this fix the hash correction!
No problem, thank you for the help and feedback @danieldk ! |
Replace ssh-askpass-sublime executable from sublime-merge that is incompatable with the nix package wrapper. Fixes #88600
Motivation for this change
Sublime merge has it's own askpass program that is used when pushing/pulling from a git repo using an ssh key with a passphrase and no ssh-agent. Currently the askpass program doesn't work (askpass dialog is never shown) due to it's custom functionality requiring it to pass a custom argv[0] argument to the sublime-merge binary which doesn't work because of the wrapper bash script added by the Nix build process to set various environment variables needed for it to run.
Things done
I've replaced the askpass program that is distributed with sublime-merge with a simple bash script that has equivalent functionality and works properly with the Nix package.
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)