Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at Rigidbody.centerOfMass. #2604

Merged
merged 8 commits into from
Jun 17, 2020
Merged

Conversation

eggrobin
Copy link
Member

Fix #2560.

@@ -239,6 +239,18 @@ internal class MainWindow : VesselSupervisedWindowRenderer {

private void RenderKSPFeatures() {
if (show_2519_debugging_ui) {
string offsets = "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we revert changes to this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted show_2519_debugging_ui.

centre_of_mass_ = centre_of_mass;
}

RigidMotion<RigidPart, EccentricPart> Part::ToEccentric() const {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find the name very clear. Maybe rigid_to_eccentric_motion would read better at the call site?

Also, I would invest in a member variable (and serialize it).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, MakeRigidToEccentricMotion, and no.

Sorry, something went wrong.

@pleroy pleroy added the LGTM label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take CoM offset into account
2 participants