Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nushell: add checkPhase without --target which causes failing tests #90714

Merged
merged 1 commit into from Jun 28, 2020
Merged

nushell: add checkPhase without --target which causes failing tests #90714

merged 1 commit into from Jun 28, 2020

Conversation

Philipp-M
Copy link
Member

@Philipp-M Philipp-M commented Jun 18, 2020 •
edited

Motivation for this change

The current version on master did break, because the default checkPhase which is used after removing the custom checkPhase by #90137 uses --target, which caused failing tests.

Things done

Readded the custom simplified checkPhase

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Br1ght0ne and marsam June 18, 2020 06:45
@Philipp-M Philipp-M changed the title nushell: fix checkPhase, which needs a debug build to succeed nushell: add checkPhase without --target which causes failing tests Jun 20, 2020
@Ma27 Ma27 merged commit 701720b into NixOS:master Jun 28, 2020
@Philipp-M Philipp-M deleted the fix-nushell-checkphase branch July 7, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 left review comments

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Philipp-M @Ma27