Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.bleach: add missing dependency packaging #90678

Merged
merged 1 commit into from Jun 17, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jun 17, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mcwitt
Copy link
Contributor

mcwitt commented Jun 17, 2020

Tested, builds successfully on darwin, and also fixes the issue reported in #90629 with nbconvert.

I don't understand why bleach builds successfully on darwin with or without this patch, but does not build as a dependency of nbconvert without it. (see #90629 (comment))

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are unrelated to change

would have posted results, but sagedoc was building, which takes >1 hour for the single threaded tests to finish

@jonringer
Copy link
Contributor

I don't understand why bleach builds successfully on darwin with or without this patch, but does not build as a dependency of nbconvert without it. (see #90629 (comment))

code paths.... python won't issue ModuleImportErrors until something at runtime tries to do so. This wasn't present in bleach, but is present in nbconvert

@jonringer jonringer merged commit ec618a9 into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants