Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devdocs-desktop: init at 0.7.1 #90660

Merged
merged 1 commit into from Jun 18, 2020
Merged

devdocs-desktop: init at 0.7.1 #90660

merged 1 commit into from Jun 18, 2020

Conversation

ymarkus
Copy link
Contributor

@ymarkus ymarkus commented Jun 17, 2020

Also added ymarkus to maintainers list.

Motivation for this change

Add a devdocs-desktop package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ymarkus
Copy link
Contributor Author

ymarkus commented Jun 17, 2020

Had to add a small gtk fix to fix a minor bug I just noticed

@ymarkus
devdocs-desktop: init at 0.7.1
99234d9 
Also added ymarkus to maintainers list.
@ymarkus
Copy link
Contributor Author

ymarkus commented Jun 17, 2020

Rebase: Changed homepage from broken url to git repo.

@teto
Copy link
Member

teto commented Jun 17, 2020

dont have much experience with appimageTools packaging so I am hesitant to merge but it works well. I didn't know the tool and it will replace zeal for sure. By any change, do you know if it is possible to consult hackage (haskell website) with it (couldn't find the info)

@ymarkus
Copy link
Contributor Author

ymarkus commented Jun 18, 2020 •
edited

Yes, looks like they do have Haskell in their collection. To be more precise, Haskell 7 & 8.

As for the appimageTools, I had a look at a few other appImage packages and followed this part of the Nixpkgs manual

@teto teto merged commit e4fd4b2 into NixOS:master Jun 18, 2020
@ymarkus ymarkus deleted the devdocs branch June 22, 2020 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

Assignees
No one assigned
Labels
8.has: documentation 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ymarkus @teto