New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup: Remove redundant implementation of TakeScreenshot #8224
Conversation
0d378b3
to
c775f4b
Compare
c6edb23
to
13619b1
Compare
If you're happy with everything now, I'll squash it all into a single commit. |
9a5c097
to
5996149
Compare
I'm sorry to burst in here this late, but what exactly is the difference between "MakeScreenshot" and "TakeScreenshot"? |
I didn't write them; I'm just refactoring them. If you have ideas for better names, now is the time to do it. |
|
I'm partial to |
7f4c37b
to
19f4be1
Compare
Thank you, @LordAro |
I don't think there's any reason we need two identical implementations of
TakeScreenshot
intoolbar_gui.cpp
andscreenshot_gui.cpp
.I also tried to make
ScreenshotConfirmationCallback
into a lambda; alas, my C++ wizardry is nowhere near that level yet.This also includes @abmyii's commit a83bd03, to fix #8232