Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vlc: 3.0.8 -> 3.0.11 (security) #90671

Merged
merged 1 commit into from Jun 17, 2020
Merged

vlc: 3.0.8 -> 3.0.11 (security) #90671

merged 1 commit into from Jun 17, 2020

Conversation

wamserma
Copy link
Member

@wamserma wamserma commented Jun 17, 2020 •
edited

Includes a security fix for CVE-2020-13428.

improved security for stored passwords (from 3.0.9)
multiple security fixes, including microdns (from 3.0.9.1)

(cherry picked from commit 745245a)

Motivation for this change

Multiple security fixes and fixed crashes, hence the version bump for stable instead of pulling in all the individual fixes as patches.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@progval @wamserma
vlc: 3.0.8 -> 3.0.11 (security)
adae0d2 
Includes a security fix for CVE-2020-13428.

improved security for stored passwords (from 3.0.9)
multiple security fixes, including microdns (from 3.0.9.1)

(cherry picked from commit 745245a)
@mmilata
Copy link
Member

mmilata commented Jun 17, 2020

IIUC libmicrodns is built as a separate package so we might want to backport #84199 too?

@mmilata mmilata added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 8.has: package (update) labels Jun 17, 2020
@wamserma
Copy link
Member Author

IIUC libmicrodns is built as a separate package so we might want to backport #84199 too?

Yes. You especially as you already mentioned the intention to backport in #84199

@mmilata
Copy link
Member

mmilata commented Jun 17, 2020

Nevermind, it's already been backported in 1d8a149, sorry.

mmilata
mmilata approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed points
  • package name fits guidelines
  • package version fits guidelines
  • package build on x86_64
  • executables tested on x86_64
  • all depending packages build
Comments

Compiles & works fine, LGTM.

@wamserma
Copy link
Member Author

ping @teto for merging

@teto teto merged commit c5fd298 into NixOS:release-20.03 Jun 17, 2020
@wamserma wamserma deleted the vlc-backport-security branch July 26, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
1.severity: security 8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wamserma @mmilata @teto @progval