Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faad2: 2.8.8 -> 2.9.2 #90669

Merged
merged 1 commit into from Jun 21, 2020
Merged

faad2: 2.8.8 -> 2.9.2 #90669

merged 1 commit into from Jun 21, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Jun 17, 2020

Changelog: https://github.com/knik0/faad2/blob/2_9_2/ChangeLog

Switch upstream to GitHub. It's unclear to me whether the repo is "official":

  • webpage still offers 2.8.8 tarball for download
  • the main repo seems to be located on sourceforge but appears inactive
  • sourceforge page links to the github repo
  • Debian ships the 2.9.2 version from github repo
Motivation for this change

Fixes: https://nvd.nist.gov/vuln/detail/CVE-2019-6956 (at least)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @codyopel

@ofborg ofborg bot requested a review from codyopel June 17, 2020 11:45
@markuskowa markuskowa self-assigned this Jun 20, 2020
@markuskowa markuskowa merged commit d7e03e2 into NixOS:staging Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

@codyopel codyopel Awaiting requested review from codyopel

Assignees

@markuskowa markuskowa

Labels
1.severity: security 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @markuskowa