New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake mac tweaks #8188
Merged
Merged
CMake mac tweaks #8188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This silences an awful lot of warnings.
I tried building a tag, and got this error: CMake Error at cmake/scripts/FindVersion.cmake:85 (string): string sub-command REGEX, mode REPLACE: regex "^[0-9.]*$" matched an empty string.
LordAro
requested changes
Jun 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing major
LordAro
previously approved these changes
Jun 5, 2020
glx22
reviewed
Jun 5, 2020
glx22
reviewed
Jun 5, 2020
glx22
reviewed
Jun 18, 2020
I applied the requested changes and rebased onto |
LordAro
approved these changes
Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few minor fixes and tweaks for the CMake build infrastructure on a Mac, kept separate from a larger and possibly more controversial change.