Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zoom-us: 5.0.418682.0603 -> 5.1.412382.0614 #90716

Merged
merged 1 commit into from Jun 18, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Jun 18, 2020

Motivation for this change
Things done

Add @doronbehar as maintainer, and update list of files to install.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Add @doronbehar as maintainer, and update list of files to install.
@NickHu
Copy link
Contributor

NickHu commented Jun 18, 2020

Builds and runs fine for me

Result of nixpkgs-review pr 90716 1

1 package built:
- zoom-us

@NickHu NickHu merged commit 1357624 into NixOS:master Jun 18, 2020
@doronbehar doronbehar deleted the update-zoom branch March 2, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants