Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nixos/sudo: default rule should be first #90699

Merged
merged 1 commit into from Jun 18, 2020
Merged

[20.03] nixos/sudo: default rule should be first #90699

merged 1 commit into from Jun 18, 2020

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jun 18, 2020

In /etc/sudoers, the last-matched rule will override all
previously-matched rules. Thus, make the default rule show up first (but
still allow some wiggle room for a user to mkBefore it), before any
user-defined rules.

(cherry picked from commit 13e2c75)

Motivation for this change

Backport of #87579.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
nixos/sudo: default rule should be first
30c703c 
In /etc/sudoers, the last-matched rule will override all
previously-matched rules. Thus, make the default rule show up first (but
still allow some wiggle room for a user to `mkBefore` it), before any
user-defined rules.

(cherry picked from commit 13e2c75)
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg test sudo

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Jun 18, 2020
@worldofpeace worldofpeace merged commit 7bb2e7e into NixOS:release-20.03 Jun 18, 2020
@cole-h cole-h deleted the sudo branch June 18, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @worldofpeace