Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libprom: init at 0.1.1 #90706

Merged
merged 1 commit into from Jun 22, 2020
Merged

libprom: init at 0.1.1 #90706

merged 1 commit into from Jun 22, 2020

Conversation

cfsmp3
Copy link

@cfsmp3 cfsmp3 commented Jun 18, 2020

Motivation for this change

Build prometheus C library which I need for something that depends on it.

Things done

It's simple derivation except that it requires a one character patch.

It's an addition, not a change, so it does not break anything.

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

@cfsmp3 cfsmp3 requested a review from cole-h June 18, 2020 04:27
cole-h
cole-h requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes I'd like to see, and a question.

pkgs/development/libraries/libprom/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libprom/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libprom/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libprom/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libprom/default.nix Outdated Show resolved Hide resolved
@cfsmp3 cfsmp3 requested a review from cole-h June 18, 2020 06:10
@cfsmp3 cfsmp3 marked this pull request as draft June 18, 2020 06:14
@cfsmp3 cfsmp3 marked this pull request as ready for review June 18, 2020 20:52
@cfsmp3 cfsmp3 requested a review from jtojnar June 18, 2020 20:52
@cfsmp3 cfsmp3 requested a review from cole-h June 18, 2020 23:15
cole-h
cole-h approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, builds fine. Thanks for bearing with my nitpicking.

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/90706
1 package built:
libprom

@cfsmp3
Copy link
Author

cfsmp3 commented Jun 22, 2020

@jtojnar can you merge or approve that someone else does it? Thanks

@cole-h
Copy link
Member

cole-h commented Jun 22, 2020

Before this gets merged, please squash your commits into a single libprom: init at 0.1.1 commit.

@cfsmp3
Copy link
Author

cfsmp3 commented Jun 22, 2020

@cole-h Done.

@purcell
Copy link
Member

purcell commented Jun 22, 2020

Disk appears full on the machine running checks, hence the failure.

@cole-h
Copy link
Member

cole-h commented Jun 22, 2020

Yep, we just dropped 3 old machines from ofborg that weren't cleaned up properly. Sorry about that.

@ofborg eval

@cfsmp3
Copy link
Author

cfsmp3 commented Jun 22, 2020

Thanks @cole-h , anything else needed from me?

@cole-h
Copy link
Member

cole-h commented Jun 22, 2020

I think you missed #90706 (comment). Aside from that, I don't see anything else wrong.

@jtojnar jtojnar merged commit 6ed1d55 into NixOS:master Jun 22, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Jun 22, 2020

Looks good. Thanks.

@purcell purcell mentioned this pull request Jul 1, 2020
Merged
10 tasks
@jtojnar jtojnar added this to Done in CMake breakage Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@purcell purcell purcell left review comments

@cole-h cole-h cole-h approved these changes

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
CMake breakage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cfsmp3 @cole-h @purcell @jtojnar