Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IPFS NixOS module: Socket unit file more precise #90693

Merged
merged 1 commit into from
Jun 18, 2020
Merged

IPFS NixOS module: Socket unit file more precise #90693

merged 1 commit into from
Jun 18, 2020
+34 −7

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jun 17, 2020 •
edited
Loading

Motivation for this change

The systemd socket unit files now more precisely track the IPFS
configuration, by including any multaddr they can make a ListenStream
for. (The daemon doesn't currently support anything which would use
ListDatagram, so we don't need to worry about that.)

The tests use some of these features.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Ericson2314
IPFS NixOS module: Socket unit file more precise

Verified

This commit was signed with the committer’s verified signature. The key has expired.
picnoir Félix
GPG key ID: EFD315F31848DBA4
Expired
Verified
Learn about vigilant mode
4044d81 
The systemd socket unit files now more precisely track the IPFS
configuration, by including any multaddr they can make a `ListenStream`
for. (The daemon doesn't currently support anything which would use
`ListDatagram`, so we don't need to worry about that.)

The tests use some of these features.
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 17, 2020
@Ericson2314 Ericson2314 merged commit 1a26ee3 into NixOS:master Jun 18, 2020
@Ericson2314 Ericson2314 deleted the ipfs-socket-unit-precision branch June 18, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Ericson2314