Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter stable (1.12.13+hotfix.9 -> 1.17.3), beta (1.15.17 -> 1.19.0-4.1.pre) and dev (1.17.0-dev.5.0 -> 1.20.0-0.0.pre) update #90681

Merged
merged 6 commits into from Jul 28, 2020
Merged

flutter stable (1.12.13+hotfix.9 -> 1.17.3), beta (1.15.17 -> 1.19.0-4.1.pre) and dev (1.17.0-dev.5.0 -> 1.20.0-0.0.pre) update #90681

merged 6 commits into from Jul 28, 2020

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Jun 17, 2020 •
edited

Motivation for this change

Flutter packages update for stable (1.12.13+hotfix.9 -> 1.17.3), beta (1.15.17 -> 1.19.0-4.1.pre) and dev (1.17.0-dev.5.0 -> 1.20.0-0.0.pre) packages.

I fixed the patches since they stopped working. For testing, I ran flutter doctor for each version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

kolaente
kolaente commented Jun 17, 2020
View reviewed changes
pkgs/development/compilers/flutter/default.nix
version = "1.12.13+hotfix.9";
sha256Hash = "1ql3zvmmk5zk47y30lajxaam04q6vr373dayq15jv4vpc0fzif1y";
version = "1.17.3";
filename = "flutter_linux_${version}-${channel}.tar.xz";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like flutter changed the naming scheme everywhere, this should probably be changed in flutter.nix to prevent boilerplate code.

@kolaente
Copy link
Member Author

@babariviere Could you review?

@babariviere
Copy link
Member

I will review it ! Thank you for your contribution !

babariviere
babariviere approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great ! I've tested the 3 versions by running this script:

nix-review pr 90681

# Stable
flutter new stable
cd stable
flutter run
# check if it runs

cd ..

# Beta
flutter-beta new beta
cd beta
flutter-beta run
# check if it works

cd ..

# Dev
flutter-dev create dev
cd dev
flutter-dev run
# check if it works

I've got no issue with it and flutter web works.
It fixes #85574.

@kolaente
Copy link
Member Author

I've got no issue with it and flutter web works.
It fixes #85574.

That sounds great!

@kolaente
Copy link
Member Author

kolaente commented Jul 5, 2020

Seems like version 1.17.5 etc has been release, I guess I'll update

@kolaente
Copy link
Member Author

kolaente commented Jul 5, 2020

I've updated stable, beta and dev versions to their newest versions respectively, I think this is ready to review again. It would be great if this could get merged before flutter releases new major versions because these might require updating the patches again...

@avdv
Copy link
Member

avdv commented Jul 6, 2020 •
edited

Result of nixpkgs-review pr 90681 1

3 packages built:
- flutter (flutterPackages.stable)
- flutterPackages.beta
- flutterPackages.dev

I also created a new app and ran flutter build apk which was successful!

👍

babariviere
babariviere approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great !

@thiagokokada
Copy link
Contributor

thiagokokada commented Jul 28, 2020 •
edited

@babariviere @worldofpeace @kolaente Can we merge this PR?

@babariviere
Copy link
Member

Yes, it's good for me but I don't have the permissions to do so.

@worldofpeace worldofpeace merged commit 7cdb25c into NixOS:master Jul 28, 2020
@worldofpeace
Copy link
Contributor

Thank you, I merged ✨

@kolaente kolaente deleted the update/flutter branch July 28, 2020 15:16
@kolaente
Copy link
Member Author

Meanwhile, Flutter updated their versions again 🙂

I guess I'll send a follow-up PR...

@kolaente
Copy link
Member Author

PR is up: #94092

@babariviere
Copy link
Member

Already ? Well done !

@kolaente
Copy link
Member Author

@babariviere Was an easy one since I did not need to modify the patches again 🙃

@kolaente kolaente mentioned this pull request Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babariviere babariviere babariviere approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kolaente @babariviere @avdv @thiagokokada @worldofpeace