Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.qtconsole: fix compile #87250

Merged
merged 2 commits into from May 8, 2020
Merged

python3Packages.qtconsole: fix compile #87250

merged 2 commits into from May 8, 2020

Conversation

urkud
Copy link
Contributor

@urkud urkud commented May 8, 2020

Motivation for this change

Compile failed saying that qtpy was not found

Things done

Added qtpy to build inputs.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@urkud
python3Packages.qtconsole: fix compile
53dda07 
It now depends on `qtpy`.
@urkud urkud requested review from FRidh and jonringer as code owners May 8, 2020 09:30
jonringer
jonringer approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 87250 1

1 package marked as broken and skipped: - ihaskell
11 packages built: - cq-editor - python27Packages.jupyter - python27Packages.qtconsole - python37Packages.ansible-kernel - python37Packages.jupyter - python37Packages.qtconsole - spyder (python37Packages.spyder) - python37Packages.spyder_3 - python38Packages.ansible-kernel - python38Packages.jupyter - python38Packages.qtconsole

@jonringer jonringer merged commit 92b43be into NixOS:master May 8, 2020
@jonringer
Copy link
Contributor

git did the right thing which was to remove the merge commit, but please rebase instead of merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @jonringer