Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tt-rss: small improvements #87261

Merged
merged 3 commits into from May 18, 2020
Merged

nixos/tt-rss: small improvements #87261

merged 3 commits into from May 18, 2020

Conversation

symphorien
Copy link
Member

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member Author

cc tt-rss maintainers @globin @zohl

@aanderse
Copy link
Member

I don't see anyone explicitly saying they have tested this. Since there isn't a NixOS test is anyone able to confirm this works with a real quick run through before we merge?

ping @symphorien @ajs124

@symphorien
Copy link
Member Author

Ah I forgot to tick the boxes but yes I tested it, notably the "restart on failure" part.

aanderse
aanderse approved these changes May 18, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I guess we're good to merge then. Thanks 🎉

@aanderse aanderse merged commit f82e267 into NixOS:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajs124 ajs124 ajs124 approved these changes

@aanderse aanderse aanderse approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tt-rss should be less verbose by default
3 participants
@symphorien @aanderse @ajs124