gitAndTools.git-fast-export: 190107 -> 200213, fix #87227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build gitAndTools.git-fast-export |
fixing involves providing it with mercurial_4 (and implicitly python27 - current released fast-export doesn't support py3 yet) and adding git to the wrapped PATH. this shouldn't be a runtime-resolved dependency.
risicle
force-pushed
the
ris-git-fast-export-200213
branch
from
93c4127
to
794c4d7
Compare
risicle
force-pushed
the
ris-git-fast-export-200213
branch
from
794c4d7
to
2caafd5
Compare
callahad
reviewed
Aug 23, 2020
| $out/bin/hg-fast-export.sh -r ../repo-hg/ --hg-hash | ||
| for s in "foo" "bar" "baz" ; do | ||
| (${git}/bin/git show | grep $s > /dev/null) && echo $s found | ||
| done |
There was a problem hiding this comment.
Sure, I'll add it for symmetry.
this creates and converts a simple hg repository - should stop us inadvertently breaking this package.
risicle
force-pushed
the
ris-git-fast-export-200213
branch
from
2caafd5
to
b91ad42
Compare
|
LGTM with the caveat that I've carefully read but have not actually run the code |
callahad
approved these changes
Aug 23, 2020
|
Good enough for me, seeing as I clearly was the first person to try using this in n months. |
👍 That's how I got roped into this last year, too (#60653)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Turns out this was broken, probably by a mercurial bump to a py3k version. Fixed & bumped (still no py3k support in a released version though). Added an
installCheckPhaseso this doesn't happen again.Would be good to get a working version of this out (maybe to stable?) what with the bitbucket mercurial shutdown approaching.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)