New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/resolved: Include dbus alias of resolved unit #87263
Conversation
This will make dbus socket activation for it work When `systemd-resolved` is restarted; this would lead to unavailability of DNS lookups. You're supposed to use DBUS socket activation to buffer resolved requests; such that restarts happen without downtime
I haven't tested this PR yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. Have not tested either.
Shouldn't this be conditional on resolved itself being enabled? |
It is. This change is in the resolved module |
You're right 🤦♂️ |
Thanks! |
This seems to have broke my build? Or it's missing an upstream component?
I don't seem to have that file in my derivation at all
Though I have
|
I did say I hadn't tested it yet ;)
Yeh I'll go give it another shot
…On Sat, May 9, 2020, 20:06 Florian Klink ***@***.***> wrote:
Yeah, sorry, seems our tooling currently doesn't properly pick it up.
Reverted in 8325e0d
<8325e0d>.
@arianvp <https://github.com/arianvp>, can you give this another try?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#87263 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEZNI7HXXX3BBOOFK7J7Q3RQWLQ5ANCNFSM4M4EF6EQ>
.
|
Found the issue. Unlike most other services in systemd; upstream doesn't include the Given we don't have Other units with this 'problem' are:
We should create dbus aliases for them too when they are enabled. |
This will make dbus socket activation for it work
Fixes #85855
Motivation for this change
When
systemd-resolved
is restarted; this would lead to unavailability of DNS lookups. You're supposed to use DBUS socket activation to buffer resolved requests; such that restarts happen without downtimeThings done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)