Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U-Boot: add Pi4 variants and support in uboot-builder #87244

Closed
wants to merge 3 commits into from
Closed

U-Boot: add Pi4 variants and support in uboot-builder #87244

wants to merge 3 commits into from

Conversation

sorki
Copy link
Member

@sorki sorki commented May 8, 2020 •
edited

Motivation for this change

Pi 4 with u-boot.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

See also #63720

@sorki sorki changed the title U-boot: add Pi4 variants and support in uboot-builder U-Boot: add Pi4 variants and support in uboot-builder May 8, 2020
@ofborg ofborg bot requested review from dezgeg, samueldr and lopsided98 May 8, 2020 07:31
@matthewbauer
Copy link
Member

matthewbauer commented May 8, 2020 •
edited

Last I checked uboot and pi4 didn't mix well. Has this changed recently? See:

I tried a bunch of things to get rpi4 64-bit u-boot to work, but ended up having to just use the rpi kernel loader.

@sorki
Copy link
Member Author

sorki commented May 9, 2020 •
edited

Thanks! Indeed it's not quite there, the dtb is missing from u-boot but already available in linux-5.6 but I can't even get serial output even with u-boot fork

    src = fetchFromGitHub {
      owner = "agherzan";
      repo = "u-boot";
      rev = "ag/rpi4";
      sha256 = "1cy58h9ljqw7yhv18n11c13pp70r98ldjbnsafmapc9mfn3gzhpa";
    };

Also tried adding armstub8-gic.bin and copied bcm2711-rpi-4-b.dtb to first partition as suggested in @samueldr s PR which I've totally missed as it was hiding in 23 hidden items of the pi support issue :(.

I'll close this for now and possibly reopen when mainline u-boot is ready - I've discovered one more cross issue during this and created #87344

@sorki sorki closed this May 9, 2020
@Robertof Robertof mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

@samueldr samueldr Awaiting requested review from samueldr samueldr is a code owner

@lopsided98 lopsided98 Awaiting requested review from lopsided98

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sorki @matthewbauer @prusnak