Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blockbook: fix go version #87284

Merged
merged 2 commits into from May 8, 2020
Merged

blockbook: fix go version #87284

merged 2 commits into from May 8, 2020

Conversation

1000101
Copy link
Member

@1000101 1000101 commented May 8, 2020

Motivation for this change

Number behavior in 1.14 has changed: golang/go#37308 and it currently breaks blockbook (prevents it from starting). Therefore, we need to use builder for go 1.13.

Moreover, I've added few parameters during build so the resulting application will have nicer UI (version+commit instead of unknown/unknown). I have left the buildtime unknown as it would render the package non-reproducible and the resulting binary file hash would change, too.

In addition, I've bumped the package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
Copy link
Member

mmahut commented May 8, 2020

Thank you, this appears to fix the current version of blockbook.

Now, let's get this fixed in master.

@mmahut mmahut merged commit 6958957 into NixOS:release-20.03 May 8, 2020
@1000101 1000101 deleted the blockbook-20.03 branch May 8, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants