dino: allow newer versions of libsignal-protocol-c #87283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also send this patch upstream? We can merge it before it gets merged upstream. |
|
It's already upstream: dino/dino@fbd70ce. |
Mic92
reviewed
May 9, 2020
pkgs/applications/networking/instant-messengers/dino/default.nix
Outdated
Show resolved
Hide resolved
jtojnar
reviewed
May 9, 2020
pkgs/applications/networking/instant-messengers/dino/default.nix
Outdated
Show resolved
Hide resolved
The exact version of libsignal-protocol-c used by dino is hard-coded to 2.3.2 because "libsignal-protocol-c has a history of breaking compatibility on the patch level". This prevents libsignal-protocol-c from being updated in NixOS#83736. Upstream already allows newer versions in the latest git master, so patch the source with this commit. Unfortunately patching doesn't work with git submodules but since the submodule is not used anyways, simply ignore this part of the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The exact version of libsignal-protocol-c used by dino is hard-coded to 2.3.2 because "libsignal-protocol-c has a history of breaking compatibility on the patch level". This prevents libsignal-protocol-c from being updated in #83736. To fix this, I do what the comment in plugins/signal-protocol/CMakeLists.txt recommends and what Arch Linux does (https://git.archlinux.org/svntogit/community.git/tree/trunk/signal-2.3.3.patch?h=packages/dino) and patch the source so that newer versions are allowed. This works fine for Arch Linux and for me.
This is the first time that I added a patch to a package. Did I do it correctly?
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)