New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
code-server: init at 3.4.1 #87258
code-server: init at 3.4.1 #87258
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/vscode-remote-development-on-nixos/3119/36 |
6fb1f15
to
0fd3ab8
Compare
I am unsure why it fails on aarch64-linux, i will remove it from supported platforms for now |
@GrahamcOfBorg build code-server |
I am using this package for some time, without any issues. Are we ready to merge it? |
Works on my machine (tm). There is apparently also an upgrade available. |
Maybe also patch out references to
and disable automatic updates if possible. |
code-server 3.4.0 is out now. BTW when updating to 3.4.0, the |
Thanks for this! I tried it on my current 20.03 NixOS box, the client-side gets disconnected and asks for reconnection every 5 seconds or so. Anyone ran into the same problem? |
I did following changes:
Missing changes (planning to implement):
Please review, it can be merged without disabled automatic updates. |
0a955ea
to
b61a3d3
Compare
Not a blocker, but do you know what this |
@Mic92 I have to check and possibly also fix that yes |
Ahh I see that I forgot to patch shebangs while fetching yarn cache. For some reason it worked on my machine, as |
On Linux in the sandbox |
@lilyball It does not seem to exist, when ofborg is building it: https://github.com/NixOS/nixpkgs/pull/87258/checks?check_run_id=750458903 which I think is right behavior. |
038342c
to
88a8fe8
Compare
@Mic92 I fixed path to ifconfig. vscode tries to get id of machine and it uses mac address (hashed) to do so, see here: https://github.com/microsoft/vscode/blob/c6c6969c3c1d5a975ed213d58a586ec1f1007c33/src/vs/base/node/id.ts#L95 Path is fixed now, so this will work. |
88a8fe8
to
88ce5a7
Compare
@GrahamcOfBorg build code-server |
Ok, I think this is now ready to be merged, it starts without any issues, does not bother with updates and looks good in general. I will deploy it on my dev environments and do some more testing, so i can confirm this version works ok. |
One small remark: The current state of this works for me, but |
I appreciate your work on this! I just set it up on my machine and it works perfectly 👍 Would be happy to see it merged 😄 I ended up installing it like this: { config, pkgs, ... }:
let
xtruder = import
(builtins.fetchTarball https://github.com/xtruder/nixpkgs/tarball/88ce5a75cbaaaf1830006501c85a6fba0c0d05c2)
{ config = config.nixpkgs.config; };
in {
environment.systemPackages = with pkgs; [
xtruder.code-server
];
systemd.services.code-server = {
enable = true;
description = "Remote VSCode Server";
after = ["network.target"];
wantedBy = ["multi-user.target"];
path = [ pkgs.go pkgs.git pkgs.direnv ];
serviceConfig = {
Type = "simple";
ExecStart = "${xtruder.code-server}/bin/code-server";
WorkingDirectory = "/home/kamal";
NoNewPrivileges = true;
User = "kamal";
Group = "nogroup";
};
};
} |
@wucke13 this must be issue with |
Might be the case, yes Edit: This is indeed a VSCode problem. |
a117fef
to
2ee80c6
Compare
One thing i noticed |
2ee80c6
to
a937391
Compare
@GrahamcOfBorg build code-server |
homepage = "https://github.com/cdr/code-server"; | ||
license = licenses.mit; | ||
maintainers = with maintainers; [ offline ]; | ||
platforms = ["x86_64-linux"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is marked as x86_64 we can remove the aarch64 checksum above.
Motivation for this change
Package
code-server
and build it from source.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)