New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #87235
Merged
Merged
Staging next #87235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build process of ghostscript has missing dependencies, causing failures in parallel builds (see hydra build https://hydra.nixos.org/build/117095669/, reported as ghostscript bug https://bugs.ghostscript.com/show_bug.cgi?id=702364 here)
libdvdread: 6.1.0 -> 6.1.1
pangomm: 2.42.0 -> 2.42.1
glibmm: 2.62.0 -> 2.64.2
libsecret: 0.20.2 -> 0.20.3
If a user provides `nativeBuildInputs = [ llvmPackages.bintools ]` or any other package containing a `${prefix}/bin/diff`, the builder could use it instead of the standard unix `diff`, causing a build failure. This updates the call to specify an abspath to `diff` and avoid reliance on `PATH`. Resolves #87081
Currently the tests take an eternity and are also sometimes flaky. By following upstream in using xdist for parallel test execution we at least get the feedback cycle down. On my machine that means instead of running this for ~25min it runs in 1 minute and 10 seconds.
This is needed by newer versions of `tensorflow` and other ML tools, so we should start working on an upgrade of the default versoin in the distribution.
When using netlib lapack/blas, the section name doesn’t match what numpy expects. So we need to add extra sections for both so that the right directory is found. The original “blas.implementation” section may not actually be still required, but it is still a good idea so that numpy know whether to apply any blas-implementation specific quirks. Fixes #86613
Some build systems look for this specifically.
ofborg
bot
added
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: python
6.topic: rust
10.rebuild-darwin-stdenv
10.rebuild-linux-stdenv
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
labels
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: python
6.topic: rust
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-darwin-stdenv
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-linux-stdenv
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)