Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A smoother correction #2561

Merged
merged 6 commits into from
May 8, 2020

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented May 7, 2020

The thresholding toggle now switches between this behaviour when off and the Fubini behaviour + PID  (as in test2550) when on.

There seems to be an improvement: in the save given in #2519 (comment), the vessel now explodes on reentry as it does in stock (the oscillations no longer slow it down enough for it to make it to the water unharmed).
However:

  1. the oscillations on descent are still larger than in stock;
  2. the westward drift on ascent is larger than in Fubini (where it was larger than in Frobenius).

Perhaps some PID tuning might help with those issues (especially 1).

attitude_correction =
Rotation<ApparentPileUp, EquivalentRigidPileUp>::Identity() *
Rotation<ApparentPileUp, ApparentPileUp>(
β,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad indent (2x).

@pleroy pleroy added the LGTM label May 8, 2020
@pleroy
Copy link
Member

pleroy commented May 8, 2020

retest this please

@eggrobin eggrobin merged commit 5c0e5b2 into mockingbirdnest:master May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants