Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jupyter_client, nbformat, notebook: fix on python2 #87222

Merged
merged 3 commits into from May 8, 2020
Merged

jupyter_client, nbformat, notebook: fix on python2 #87222

merged 3 commits into from May 8, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented May 7, 2020 •
edited

Motivation for this change

jupyter_client dropped python2 support and apparently there were some mixups at the recent python packages update.

CC @FRidh

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
python2.pkgs.jupyter_client: pin at 5.x
f86d48f 
Version 6.x dropped python2 compatibility.
@timokau
Revert "python3Packages.nbformat: 4.4.0 -> 5.0.4"
acbac66 
This reverts commit 7ba0848.

Mistaken update of the pinned python2 version.
@timokau
Revert "python3Packages.notebook: 5.7.8 -> 6.0.3"
6cc031e 
This reverts commit 62425ee.

Mistaken update of the pinned python2 version.
@timokau timokau changed the title Python2 fixes jupyter_client, nbformat, notebook: fix on python2 May 7, 2020
@timokau
Copy link
Member Author

timokau commented May 7, 2020

Hopefully I'll be able to update sage to python3 soon so that I can stop caring about these things.

@ofborg ofborg bot requested a review from globin May 7, 2020 22:28
@FRidh
Copy link
Member

FRidh commented May 8, 2020

Thank you. I thought my branch with changes was mostly finished, but this seemed to break more than I thought.

@FRidh
Copy link
Member

FRidh commented May 8, 2020

seems like I forgot to specify again explicitly default.nix when running my updater...

@FRidh
Copy link
Member

FRidh commented May 8, 2020

Still would like to have a way to describe version or update bounds in an expression, so an evaluation error would occur.

@FRidh FRidh merged commit 236fdbc into NixOS:master May 8, 2020
@timokau timokau deleted the python2-fixes branch May 10, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @FRidh