Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tartube: 2.0.016 -> 2.1.0 #87269

Merged
merged 2 commits into from Jun 16, 2020
Merged

tartube: 2.0.016 -> 2.1.0 #87269

merged 2 commits into from Jun 16, 2020

Conversation

luc65r
Copy link
Contributor

@luc65r luc65r commented May 8, 2020

Motivation for this change

I updated Tartube and added playsound which is a new dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@luc65r
Copy link
Contributor Author

luc65r commented May 8, 2020

Even though there is gobject-introspection in nativeBuildInputs and pygobject3 in propagatedBuildInputs, it can't find gi when it runs setup.py.
It launches and can download videos.

@ofborg ofborg bot requested a review from mkg20001 May 8, 2020 15:03
@jonringer jonringer changed the title Pkg/tartube tartube: 2.0.016 -> 2.1.0 May 8, 2020
@Ekleog
Copy link
Member

Ekleog commented Jun 16, 2020

Thankyou for this PR! :D

@Ekleog Ekleog merged commit 53d16b8 into NixOS:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants