Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 41caaaad365b
Choose a base ref
...
head repository: NixOS/nix
compare: d3d8186c9c9a
Choose a head ref
  • 13 commits
  • 10 files changed
  • 2 contributors

Commits on May 6, 2020

  1. WIP: add unit tests for libutil 

    This is a proof on concept to evaluate writing unit tests for Nix using
google test (https://github.com/google/googletest).

In order to execute tests:

$ make unit-tests
$ ./unit-tests

The Makefile rules for `unit-tests` is a complete hack.
    @gilligan
    gilligan committed May 6, 2020
    Copy the full SHA
    58ed1e6 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Use ASSERT_EQ instead of ASSERT_STREQ 

    No need to use `c_str()` in combination with `ASSERT_STREQ`.
It's possible to just use ASSERT_EQ on std::string
    @gilligan
    gilligan committed May 7, 2020
    1
    Copy the full SHA
    987b3d6 View commit details
    Browse the repository at this point in the history

  2. Remove replaceInSet 

    The function isn't being used anywhere so it seems safe to remove
    @gilligan
    gilligan committed May 7, 2020
    Copy the full SHA
    1f3602a View commit details
    Browse the repository at this point in the history

  3. Drop unnecessary std::string

    @gilligan
    gilligan committed May 7, 2020
    Copy the full SHA
    73d0b5d View commit details
    Browse the repository at this point in the history

Commits on May 8, 2020

  1. Move unit tests to sr/libutil/tests, use mk make rules

    @edolstra
    edolstra committed May 8, 2020
    Copy the full SHA
    7cc7cef View commit details
    Browse the repository at this point in the history

  2. Fix warning

    @edolstra
    edolstra committed May 8, 2020
    Copy the full SHA
    72b9d97 View commit details
    Browse the repository at this point in the history

  3. make check: Run unit tests

    @edolstra
    edolstra committed May 8, 2020
    Copy the full SHA
    7898cdb View commit details
    Browse the repository at this point in the history

  4. Don't install unit tests

    @edolstra
    edolstra committed May 8, 2020
    Copy the full SHA
    ca65752 View commit details
    Browse the repository at this point in the history

  5. configure: Look for gtest

    @edolstra
    edolstra committed May 8, 2020
    Copy the full SHA
    5b8883f View commit details
    Browse the repository at this point in the history

  6. Enable dirOf test 

    Adjusted the doc comment for `dirOf` to reflect the implementation
behavior.
    @gilligan
    gilligan committed May 8, 2020
    Copy the full SHA
    e3df9c2 View commit details
    Browse the repository at this point in the history

  7. Enable baseNameOf test 

    Add note about removal of trailing slashes in the doc comment of
baseNameOf and enabled the test.
    @gilligan
    gilligan committed May 8, 2020
    Copy the full SHA
    2191141 View commit details
    Browse the repository at this point in the history

  8. Enable toLower umlauts test 

    Update comment and enable the test
    @gilligan
    gilligan committed May 8, 2020
    Copy the full SHA
    181a47d View commit details
    Browse the repository at this point in the history

  9. Merge pull request #3571 from gilligan/nix-unit-testing 

    Add unit tests
    @edolstra
    edolstra committed May 8, 2020
    Copy the full SHA
    d3d8186 View commit details
    Browse the repository at this point in the history