mpd: add services.mpd.fluidsynth option #87270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fluidsynth is compiled in but soundfont-fluid needs to be explicitly
pulled in and path configured, an option makes it much simpler to use
Things done
sandbox
innix.conf
on non-NixOS linux)I tried running
nixos/tests/mpd.nix
but it looks like my hosts' config firewall bled into it? or it doesn't work anymore because of firewall; port 6600 was refused...Anyway I tested manually via build-vm and it works (both pulling the package and config looked ok with & without new option set)
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)mpd maintainers @tobim @fpletz @ehmry @astsmtl