Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isabelle: 2018 -> 2020 #87224

Merged
merged 4 commits into from Aug 23, 2020
Merged

isabelle: 2018 -> 2020 #87224

merged 4 commits into from Aug 23, 2020

Conversation

Sohalt
Copy link
Contributor

@Sohalt Sohalt commented May 7, 2020

Motivation for this change

Update to current version

cc @jwiegley

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Sohalt
Copy link
Contributor Author

Sohalt commented May 7, 2020

I couldn't test this on Darwin.

@ofborg ofborg bot requested a review from jwiegley May 7, 2020 23:26
@yrashk
Copy link
Contributor

yrashk commented May 8, 2020

While we're at it, the license in this derivation states LGPL, the website says "Isabelle is distributed for free under a conglomerate of open-source licenses, but the main code-base is subject to BSD-style regulations". Should we change it to BSD?

@Sohalt @puzzlewolf
Fixup
877af72 
Co-authored-by: puzzlewolf <23097564+puzzlewolf@users.noreply.github.com>
@Lassulus Lassulus merged commit 15d9850 into NixOS:master Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf left review comments

@jwiegley jwiegley Awaiting requested review from jwiegley

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Sohalt @yrashk @puzzlewolf @Lassulus