Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #121, da57fb5: check StorageOp register range only once #124

Merged
merged 1 commit into from May 8, 2020
Merged

Fix #121, da57fb5: check StorageOp register range only once #124

merged 1 commit into from May 8, 2020

Conversation

glx22
Copy link
Contributor

@glx22 glx22 commented May 8, 2020

The range is already checked in reduce()

FLHerne
FLHerne approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@FLHerne FLHerne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, confirmed it's still checked for the correct range.

@FLHerne FLHerne merged commit 6921af0 into OpenTTD:master May 8, 2020
@glx22 glx22 deleted the fix_121 branch May 8, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FLHerne FLHerne FLHerne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glx22 @FLHerne