postgres: Do not log timestamp #87219
Conversation
By default, postgres prefixes each log line with a timestamp. On NixOS logs are written to journal anyway, so they include an external timestamp, so the timestamp ends up being printed twice, which clutters the log. * Add a module option to change the log prefix. * Set it to upstream default sans timestamp.
|
@2chilled sorry, accidental ping |
| @@ -192,6 +193,17 @@ in | |||
| ''; | |||
| }; | |||
|
|
|||
| logLinePrefix = mkOption { | |||
| type = types.str; | |||
| default = "[%p] "; | |||
There was a problem hiding this comment.
Shouldn't we remove the %p as well then? The PID is also logged in journald.
There was a problem hiding this comment.
Journal only shows (and records, IIUC) the PID of the main process, while postgres spawns and logs from a lot of subprocesses.
To be honest, I am not exactly sure if this is how it is supposed to work, i.e. why journalctl always shows the PID of the parent process – I would expect it to save the PID of the process that actually wrote the message. This might be something worth looking into later.
There was a problem hiding this comment.
Uhm, AFAICS on my machine, journald doesn't show the parent's PID on each log-line, I'm using systemd 245 though.
There was a problem hiding this comment.
I don’t know about that. The code that prints it has been there since, at least, 2012. And if you google “journalctl” and go to images, you’ll see that they all contain the pid.
There was a problem hiding this comment.
not sure if I'm misunderstanding you, but I meant that the PID of the process producing the line is shown in the line and not the PID of the main process of a unit.
There was a problem hiding this comment.
Oh! Sorry, I misunderstood you.
I don’t see any release notes in the last couple versions that seem to be relevant. Can you try specifically with postgres please? My theory is that maybe this wrapping into bash scripts that we do breaks something. What I see in my journal is that the PID that journalctl prints is always the same for postgresql.service and the PIDs printed by postgres itself are different.
|
This may break in fun ways if |
|
I don’t think it can break, as options coming later in the file override the ones before them, so setting |
Co-authored-by: Mario Rodas <marsam@users.noreply.github.com>
By default, postgres prefixes each log line with a timestamp. On NixOS
logs are written to journal anyway, so they include an external
timestamp, so the timestamp ends up being printed twice, which clutters
the log.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)