Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnu-config: 2019-04-15 -> 2020-05-04 #87234

Merged
merged 1 commit into from Aug 3, 2020
Merged

gnu-config: 2019-04-15 -> 2020-05-04 #87234

merged 1 commit into from Aug 3, 2020

Conversation

ehmry
Copy link
Contributor

@ehmry ehmry commented May 8, 2020

Motivation for this change

Update the config.sub and config.guess files that are replaced during some cross-compiles. This is specifically to support the Genode target that was added to lib/systems a few months ago. Note that the Genode toolchain and libc are still in an overlay and not in Nixpkgs.

This is a neat feature so I added a mention to the Nixpkgs manual.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: stdenv Standard environment 8.has: documentation labels May 8, 2020
@ofborg ofborg bot requested a review from dezgeg May 8, 2020 04:09
@FRidh FRidh added this to WIP in Staging via automation May 8, 2020
@FRidh FRidh moved this from WIP to Needs review in Staging May 8, 2020
@ehmry
Copy link
Contributor Author

ehmry commented May 8, 2020

Platform Changed paths
x86_64-linux 6650
i686-linux 5816
aarch64-linux 29827

Ouch

@ehmry ehmry force-pushed the staging branch 3 times, most recently from ba82fda to 173a805 Compare May 15, 2020 21:34
@FRidh FRidh added this to the 20.09 milestone Jun 19, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/redox-nix-was-where-does-the-cc-environment-variable-come-from/7784/10

@ehmry
gnu-config: 2019-04-15 -> 2020-05-04
f5ef00a 
Update gnu-config (config.sub, config.guess) to suport the Genode
platform and apply the updateAutotoolsGnuConfigScriptsHook to Genode
cross-compilation.
@Ericson2314 Ericson2314 merged commit c0b06ef into NixOS:staging Aug 3, 2020
Staging automation moved this from Needs review to Done Aug 3, 2020
@ehmry ehmry deleted the staging branch August 3, 2020 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ehmry @nixos-discourse @Ericson2314 @FRidh