Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krop: install desktop file #87282

Merged
merged 1 commit into from May 12, 2020
Merged

krop: install desktop file #87282

merged 1 commit into from May 12, 2020

Conversation

symphorien
Copy link
Member

Motivation for this change

use krop from a graphical launcher

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aaronjanse
Copy link
Member

Quick note: I think "dektop" in the commit title is a typo. Not sure if that matters.

@symphorien
Copy link
Member Author

Ah right, fixed. Thanks :)

@symphorien symphorien changed the title krop: install dektop file krop: install desktop file May 8, 2020
@Lassulus Lassulus merged commit 83b618a into NixOS:master May 12, 2020
@doronbehar doronbehar mentioned this pull request May 14, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@symphorien @aaronjanse @doronbehar @Lassulus