Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nml 0.5.0 - industries transported_last_month_pct variable not in range 0..100 #120

Closed
jrook1445 opened this issue May 8, 2020 · 0 comments
Closed

nml 0.5.0 - industries transported_last_month_pct variable not in range 0..100 #120

jrook1445 opened this issue May 8, 2020 · 0 comments

Comments

@jrook1445
Copy link

jrook1445 commented May 8, 2020 •
edited

Expected: industries transported_last_month_pct variable to return values in range 0..100

Observed: appears to return values in range 0..255

Unsure whether this is intended behaviour or not. #83 says: 0x71 Last month transported (FF = 100%), as do NFO docs, but NML docs say range 0..100

steps to reproduce: test newgrf and screenshot attached

Linux Mint 19.3
nml 0.5.0
PIL: 5.4.1
PLY: 3.11
python 3.5.2 (pyrun 2.2.3)
OpenTTD: 1.10.1

transported_last_month_pct.tar.gz
FLHerne added a commit to FLHerne/nml that referenced this issue May 8, 2020
@FLHerne
Fix OpenTTD#120: Value range of transported_last_month_pct should be …
e915419 
…0..100.

This was overlooked when it was added in PR OpenTTD#84.
@FLHerne FLHerne closed this as completed in 1c378e2 May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrook1445