Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pc-ble-driver: init at 4.1.1 #91173

Closed
wants to merge 1 commit into from
Closed

pc-ble-driver: init at 4.1.1 #91173

wants to merge 1 commit into from

Conversation

siriobalmelli
Copy link
Contributor

@siriobalmelli siriobalmelli commented Jun 20, 2020 •
edited

This is a requirement for the already-existing pc-ble-driver-py python module.

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

This utility required to maintain a Nix CI

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@siriobalmelli siriobalmelli force-pushed the add/pc-ble-driver branch 3 times, most recently from 7622570 to 3f21fd7 Compare July 1, 2020 14:16
@siriobalmelli
pc-ble-driver: init at 4.1.1
719c89d 
This is a requirement for the already-existing pc-ble-driver-py python module.

Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli
Copy link
Contributor Author

siriobalmelli commented Jul 19, 2020 •
edited

This sat here for a month ... and was then independently done (and immediately committed) by @jonas-schievink here: e1a1b97

@siriobalmelli
Copy link
Contributor Author

siriobalmelli commented Jul 19, 2020 •
edited

... as committed will not build on Darwin. Reopening with patch: #93487

@siriobalmelli siriobalmelli changed the title pc-ble-driver: init at 4.1.1 pc-ble-driver: fix Darwin build Jul 19, 2020
@siriobalmelli siriobalmelli mentioned this pull request Jul 19, 2020
Merged
10 tasks
@siriobalmelli siriobalmelli changed the title pc-ble-driver: fix Darwin build pc-ble-driver: init at 4.1.1 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@siriobalmelli