thunderbird: cleanups #91194
Merged
thunderbird: cleanups #91194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has not been used since 2015: mozilla/gecko-dev@42c9261
It is only optionally dlopened by crash reporter to try to get system proxy settings but no system stores proxy in GConf these days so it is completely useless. https://github.com/mozilla/gecko-dev/blob/97c590ed5532a7b382b5b8500c109de8f1d831e3/toolkit/crashreporter/client/crashreporter_gtk_common.cpp#L121-L122
It is deprecated and has been removed ages ago: https://bugzilla.mozilla.org/show_bug.cgi?id=694570 It persists in the crash reporter for some reason but it is optional there: https://github.com/mozilla/gecko-dev/blob/f66f5a235e7d74c29b951316f73001126a056734/toolkit/crashreporter/client/crashreporter_linux.cpp#L366-L370
It has not been used for ages: https://bugzilla.mozilla.org/show_bug.cgi?id=687766
It has not been used for ages: https://bugzilla.mozilla.org/show_bug.cgi?id=687766
It is deprecated and has been removed ages ago: https://bugzilla.mozilla.org/show_bug.cgi?id=694570 It persists in the crash reporter for some reason but it is optional there: https://github.com/mozilla/gecko-dev/blob/f66f5a235e7d74c29b951316f73001126a056734/toolkit/crashreporter/client/crashreporter_linux.cpp#L366-L370
It is only optionally dlopened by crash reporter to try to get system proxy settings but no system stores proxy in GConf these days so it is completely useless. https://github.com/mozilla/gecko-dev/blob/97c590ed5532a7b382b5b8500c109de8f1d831e3/toolkit/crashreporter/client/crashreporter_gtk_common.cpp#L121-L122
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 11-100
and removed
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues #39976 and #39975 for Thunderbird and Firefox.
cc @taku0, @lovesegfault, @vcunat (#76118)