Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emu2: init at unstable-2020-06-04 #91193

Merged
merged 1 commit into from Jul 3, 2020
Merged

emu2: init at unstable-2020-06-04 #91193

merged 1 commit into from Jul 3, 2020

Conversation

dramaturg
Copy link
Contributor

Motivation for this change

This adds the emu2 DOS emulator.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/210

danieldk
danieldk suggested changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small suggested changes.

pkgs/misc/emulators/emu2/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/emu2/default.nix Outdated Show resolved Hide resolved
pkgs/misc/emulators/emu2/default.nix Show resolved Hide resolved
danieldk
danieldk approved these changes Jul 3, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Result of nixpkgs-review pr 91193 1

1 package built:
- emu2

Binary runs as expected.

For a future update, you may want to check if Darwin works as well. It seems that upstream made some changes to accommodate Darwin:

dmsc/emu2#4

@danieldk danieldk merged commit e932a72 into NixOS:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dramaturg @nixos-discourse @danieldk