Add: [CMake] More improvements for install #8218
Conversation
|
@Nik-mmzd I updated man page naming |
|
All seems to work as expected (CMAKE_INSTALL_DATADIR, CMAKE_INSTALL_DOCDIR, CMAKE_INSTALL_MANDIR, BINARY_NAME, man page naming) Found one more missing thing: |
glx22
changed the title
|
I assumed if someone wants to change binary name, it should be reflected to install paths. |
|
Why should we provide an ability to rename the output executable? |
|
It was supported before cmake move and some packagers use this feature, mainly for nightly packages. |
| set(MAN_BINARY_FILE ${CMAKE_BINARY_DIR}/docs/${BINARY_NAME}.6) | ||
| install(CODE | ||
| " | ||
| execute_process(COMMAND ${CMAKE_COMMAND} -E copy ${MAN_SOURCE_FILE} ${MAN_BINARY_FILE}) |
There was a problem hiding this comment.
There was a problem hiding this comment.
yeah configure_file works here too, anyway the file is always copied during install, because gzip compresses it in-place :)
There was a problem hiding this comment.
Very few of the build systems I've ever worked with (as a packager myself) have automatically compressed the man page. The few times they have, about half the time it's done incorrectly, e.g. not with gzip -9, or using bzip2 as the compressor, or something, and I have to redo it in my script.
For instance, wesnoth/wesnoth doesn't compress its man pages upon install, and that's just fine with me.
Default path will be different, but the switch to cmake already changed some. And package maintainers usually don't rely on default values.
Also added a way to rename openttd executable.
Closes #8204