Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.vim-language-server: init at 2.1.0 #91142

Merged
merged 1 commit into from Aug 4, 2020
Merged

nodePackages.vim-language-server: init at 2.1.0 #91142

merged 1 commit into from Aug 4, 2020

Conversation

leungbk
Copy link
Member

@leungbk leungbk commented Jun 20, 2020

Motivation for this change

Add vim-language-server, a LSP-compliant server for Vimscript

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matt-snider
matt-snider reviewed Jun 28, 2020
View reviewed changes
Copy link
Contributor

@matt-snider matt-snider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leungbk Nice addition! I was just looking to use this myself and noticed it was missing.

The changes (besides conflicts) look good to me. I built it from your branch and tried it out in vim with LanguageClient-neovim - let g:LanguageClient_serverCommands.vim = ['/nix/store/.../vim-language-server', '--stdio'] - and it works :-)

@calbrecht I haven't reviewed any PRs yet in nixpkgs, but I'd like to start. Since you are the suggested reviewer, is there anything else to be checked usually? I did read the relevant documentation, but I'm not clear on how one should review changes in node-packages.nix or similar, to ensure that the appropriate generated changes are present and haven't been tinkered with or done erroneously.

@leungbk leungbk force-pushed the nodePackages-vimls branch 3 times, most recently from 470cc04 to 8e19268 Compare June 28, 2020 23:06
@calbrecht
Copy link
Member

@matt-snider although beeing suggested as reviewer, i did not do so much reviews already. But i know there is this chapter about reviewing in nixpkgs manual.

@matt-snider
Copy link
Contributor

@calbrecht Thanks for the response. I think the issue I mentioned with node-packages.nix is probably irrelevant since any incorrect changes will be overwritten in later revisions anyways. Doesn't seem important.

@leungbk It looks good to me, and like I said, it works, but I don't have merge rights for this repo, so for now I can just review and wait for someone else to merge it

@infinisil infinisil changed the title nodePackages.vim-language-server: init at 1.9.0 nodePackages.vim-language-server: init at 2.1.0 Aug 4, 2020
@infinisil infinisil merged commit d418434 into NixOS:master Aug 4, 2020
@raboof raboof mentioned this pull request Aug 10, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-snider matt-snider matt-snider approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leungbk @calbrecht @matt-snider @infinisil