Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcache-tools: Fix the cross compilation #91109

Merged
merged 1 commit into from Jun 19, 2020
Merged

bcache-tools: Fix the cross compilation #91109

merged 1 commit into from Jun 19, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Jun 19, 2020 •
edited

Fix #90726.

Build log 
these derivations will be built:
  /nix/store/q6zsrp2l2fmq0lc1950yz0mszdxj0cvq-bcache-tools-1.0.7-aarch64-unknown-linux-gnu.drv
building '/nix/store/q6zsrp2l2fmq0lc1950yz0mszdxj0cvq-bcache-tools-1.0.7-aarch64-unknown-linux-gnu.drv'...
unpacking sources
unpacking source archive /nix/store/rgwm01hfhmbba4nbfbayimb81v9wqrnb-bcache-tools-1.0.7.tar.gz
source root is bcache-tools-1.0.7
setting SOURCE_DATE_EPOCH to timestamp 1399729101 of file bcache-tools-1.0.7/probe-bcache.c
patching sources
applying patch /nix/store/2q3z7587yhlz0i2xvfvvap42zk5carlv-bcache-udev-modern.patch
patching file 69-bcache.rules
patching file Makefile
Hunk #1 succeeded at 9 with fuzz 1.
patching file bcache-register
applying patch /nix/store/03sl46khd8gmjpsad7223m32ma965vy9-fix-static.patch
patching file bcache.c
updateAutotoolsGnuConfigScriptsPhase
configuring
no configure script, doing nothing
building
build flags: SHELL=/nix/store/n313xks5ym0s0a5v8a5285rmnmvy6ms9-bash-4.4-p23/bin/bash PREFIX=/nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu UDEVLIBDIR=/nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/lib/udev/
aarch64-unknown-linux-gnu-gcc -O2 -Wall -g `aarch64-unknown-linux-gnu-pkg-config --cflags uuid blkid`   -c -o bcache.o bcache.c
aarch64-unknown-linux-gnu-gcc -O2 -Wall -g `aarch64-unknown-linux-gnu-pkg-config --cflags uuid blkid`    make-bcache.c bcache.o  `aarch64-unknown-linux-gnu-pkg-config --libs uuid blkid` -o make-bcache
aarch64-unknown-linux-gnu-gcc -O2 -Wall -g `aarch64-unknown-linux-gnu-pkg-config --cflags uuid blkid`    probe-bcache.c  `aarch64-unknown-linux-gnu-pkg-config --libs uuid blkid` -o probe-bcache
aarch64-unknown-linux-gnu-gcc -O2 -Wall -g -std=gnu99    bcache-super-show.c bcache.o  `aarch64-unknown-linux-gnu-pkg-config --libs uuid` -o bcache-super-show
installing
install flags: SHELL=/nix/store/n313xks5ym0s0a5v8a5285rmnmvy6ms9-bash-4.4-p23/bin/bash PREFIX=/nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu UDEVLIBDIR=/nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/lib/udev/ install
install -m0755 make-bcache bcache-super-show    /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/sbin/
install -m0644 69-bcache.rules  /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/lib/udev//rules.d/
install -m0644 -- *.8 /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/share/man/man8/
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu
shrinking /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/sbin/bcache-super-show
shrinking /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/sbin/make-bcache
gzipping man pages under /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/share/man/
aarch64-unknown-linux-gnu-strip is /nix/store/5yman7cwrilchfs2npckj1zchnj1ss0f-aarch64-unknown-linux-gnu-binutils-2.31.1/bin/aarch64-unknown-linux-gnu-strip
stripping (with command aarch64-unknown-linux-gnu-strip and flags -S) in /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/lib  /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/sbin
patching script interpreter paths in /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu
checking for references to /build/ in /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu...
moving /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/sbin/* to /nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu/bin
/nix/store/p8s4q80cysn4cjcn2b7ad7yr8wm84sy0-bcache-tools-1.0.7-aarch64-unknown-linux-gnu
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos mentioned this pull request Jun 19, 2020
Closed
@ofborg ofborg bot requested a review from bjornfor June 19, 2020 17:25
@primeos primeos force-pushed the bcache-tools-fix-cross-compilation branch from feac3a6 to 5830258 Compare June 19, 2020 21:14
@ofborg ofborg bot requested a review from bjornfor June 19, 2020 21:22
@flokli flokli merged commit 0ee4259 into NixOS:master Jun 19, 2020
@Ericson2314 Ericson2314 mentioned this pull request Jun 20, 2020
Open
@Ericson2314
Copy link
Member

Ericson2314 commented Jun 20, 2020 •
edited

Submitted a PR upstream: g2p/bcache-tools#33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleverca22 cleverca22 cleverca22 left review comments

@flokli flokli flokli approved these changes

@bjornfor bjornfor Awaiting requested review from bjornfor

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bcache-tools doesn't cross-compile
5 participants
@primeos @Ericson2314 @bjornfor @flokli @cleverca22