Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: aiohttp/psutil/uvloop Darwin fixes #91118

Merged
merged 3 commits into from Jun 20, 2020
Merged

Conversation

simonchatts
Copy link
Contributor

Three minor fixes for Python packages on Darwin.

aiohttp and uvloop just need tests disabling; I've tested the resulting packages still work, at least for my use case.

The issue with psutil was correctly diagnosed in #82524, but that hit a stumble with the boolean logic, so this fixes that.

The test disablement in uvloop is slightly unusual, but that's because the way the tests are run is already slightly unusual, and so disabledTests didn't work.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

PR NixOS#82524 correctly diagnosed the problem, but slightly fluffed the boolean
logic (disable tests for Darwin as well as non-x86_64 arch).
Disable a non-critical test known to fail on Darwin (see aio-libs/aiohttp#3572)
Skip tests that fail on Darwin
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 19, 2020
@ofborg ofborg bot requested review from costrouc and dotlambda June 19, 2020 19:34
@FRidh FRidh merged commit a48adb3 into NixOS:master Jun 20, 2020
@simonchatts simonchatts deleted the darwin-fixes branch June 20, 2020 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants