fastmod: init at 0.4.0 #91196
fastmod: init at 0.4.0 #91196
Conversation
pkgs/tools/text/fastmod/default.nix
Outdated
| description = "A utility that makes sweeping changes to large, shared code bases"; | ||
| homepage = "https://github.com/facebookincubator/fastmod"; | ||
| license = "Apache-2.0"; | ||
| maintainers = with maintainers; [ swolchok ]; |
There was a problem hiding this comment.
Add a separate commit (ordered before the commit that adds this derivation) to add yourself to maintainers/maintainer-list.nix. This should fix the ofborg error (since swolchok is currently undefined).
There was a problem hiding this comment.
@danieldk thanks for your quick response and suggestions. I've applied them and added myself as a maintainer. All CI checks passed. PTAL.
There was a problem hiding this comment.
Thanks for making these changes! Could you change the first line of the message of the commit where you add yourself to maintainers.nix to:
maintainers: add jduan
And then squash all the other commits (the ones for the derivation itself) into one commit with the following initial line in the commit message:
fastmod: init at 0.4.0
All commit messages in nixpkgs follow the same patterns to make it easy to find what was changed when ;).
In the commit history, the commit that adds you to maintainers.nix should be ordered before the one where the derivation is added.
If you need help fixing up the history, you can enable Allow edits and access to secrets by maintainers on in the rightmost column and let me know, and I can do the cleanup.
There was a problem hiding this comment.
@danieldk thanks for suggesting the convention used by this repo! I've changed the commit history as you suggested. PTAL. Again, thanks for making my first contribution to this repo a pleasant experience!
jduan
force-pushed
the
jduan--add-fastmod
branch
from
d2331d6
to
13642f5
Compare
jduan
force-pushed
the
jduan--add-fastmod
branch
from
13642f5
to
33ccb8b
Compare
jduan
force-pushed
the
jduan--add-fastmod
branch
from
d7b6717
to
5f48a53
Compare
|
@danieldk thanks for merging this PR and guiding me along the way. Really appreciate your time! |
Motivation for this change
This adds a package for https://github.com/facebookincubator/fastmod, a CLI tool for refactoring code.
Things done
I ran
nix-build -A fastmod default.nixand tested the binary built. It worked as expected.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)