Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite: 3.32.2 -> 3.32.3 #91112

Merged
merged 2 commits into from Jul 2, 2020
Merged

sqlite: 3.32.2 -> 3.32.3 #91112

merged 2 commits into from Jul 2, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Jun 19, 2020

Motivation for this change

New release of sqlite, also updates sqlite-analyzer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edolstra and np June 19, 2020 18:21
@FRidh FRidh changed the base branch from master to staging June 20, 2020 05:39
@FRidh FRidh added this to WIP in Staging via automation Jun 20, 2020
@Luflosi
Copy link
Contributor Author

Luflosi commented Jun 29, 2020

Should I rebase this on top of the latest staging branch since I originally made this PR against the master branch? Is there anything else I can do?

@FRidh FRidh merged commit 052e315 into NixOS:staging Jul 2, 2020
Staging automation moved this from WIP to Done Jul 2, 2020
@Luflosi Luflosi deleted the update/sqlite branch July 2, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @FRidh