Hintfmt percent test, and fix #3724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
reviewed
Jun 21, 2020
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Jun 21, 2020
There is a correctnes issue here, but NixOS#3724 will fix that. This is just a cleanup for brevity's sake.
Co-authored-by: John Ericson <git@JohnEricson.me>
bburdette
changed the title
…normaltxt on plain_string hintfmt
Ericson2314
approved these changes
Jun 22, 2020
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Apr 19, 2022
There is a correctnes issue here, but NixOS#3724 will fix that. This is just a cleanup for brevity's sake.
Ericson2314
added a commit
to obsidiansystems/nix
that referenced
this pull request
Apr 19, 2022
There is a correctnes issue here, but NixOS#3724 will fix that. This is just a cleanup for brevity's sake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the issue from #3720, I thought adding some tests would be a good idea.
Also there's a tentative solution here... its maybe a little inelegant to search-and-replace on percent, but its simpler than some other things I thought of. Still thinking though.