Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buoto/gotests-vim as vim plugins #91163

Merged
merged 2 commits into from
Jun 20, 2020
Merged

Conversation

shihanng
Copy link
Contributor

@shihanng shihanng commented Jun 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Commits were generated by running:

./update.py --proc=1 --add "buoto/gotests-vim"

Sorry, something went wrong.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/91163
1 package failed to build:
vimPlugins.YouCompleteMe

43 packages built:
vimPlugins.ale vimPlugins.calendar-vim vimPlugins.coc-fzf vimPlugins.coc-nvim vimPlugins.conjure vimPlugins.csv-vim vimPlugins.defx-nvim vimPlugins.deol-nvim vimPlugins.deoplete-fish vimPlugins.deoplete-jedi vimPlugins.deoplete-khard vimPlugins.deoplete-nvim vimPlugins.ghcid vimPlugins.gotests-vim vimPlugins.iosvkem vimPlugins.lh-brackets vimPlugins.lightline-vim vimPlugins.neosnippet-vim vimPlugins.nord-vim vimPlugins.nvim-lsp vimPlugins.papercolor-theme vimPlugins.quick-scope vimPlugins.splitjoin-vim vimPlugins.tcomment_vim vimPlugins.traces-vim vimPlugins.vim-SyntaxRange vimPlugins.vim-airline vimPlugins.vim-cursorword vimPlugins.vim-devicons vimPlugins.vim-ghost vimPlugins.vim-gitgutter vimPlugins.vim-go vimPlugins.vim-hybrid-material vimPlugins.vim-jsdoc vimPlugins.vim-lsc vimPlugins.vim-markdown vimPlugins.vim-polyglot vimPlugins.vim-racer vimPlugins.vim-visual-multi vimPlugins.vim-which-key vimPlugins.vista-vim vimPlugins.yats-vim vimPlugins.zig-vim

@jonringer
Copy link
Contributor

@shihanng thanks for opening your first PR with nixpkgs! :)

@jonringer jonringer merged commit f2b3814 into NixOS:master Jun 20, 2020
@shihanng shihanng deleted the gotests-vim branch June 27, 2020 00:04
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants