[20.03] backport: nixos/btrfs autoScrub: don't fail when scrub finishes successfully #91162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 55d16d5)
|
Have you only tried this once or have you been using it for a while? The testing standard for stable-branches is a bit higher than unstable, we should be reasonably sure that this will not break anybodies setup. Given that, do you think its good to go? |
|
When I opened the PR, I switched my system to this branch, and successfully ran one scrub and cancelled one. Then I switched my system to stable again. |
|
A one-time test might not catch unintended longterm consequences or breakage in edge-cases. In that case I'd rather let this sit in unstable for a bit. If nothing has happened until then, please ping me again in a week. Or if you're actively testing it yourself, 3 days are probably enough too. |
|
cc @timokau |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 55d16d5)
I tested that a scrub can finish successfully and be cancelled successfully.