Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nixos-20.03 backport] Backport mutt 1.14.4 security issue patch #91197

Closed
wants to merge 1 commit into from
Closed

[nixos-20.03 backport] Backport mutt 1.14.4 security issue patch #91197

wants to merge 1 commit into from

Conversation

matthiasbeyer
Copy link
Contributor

This was not yet tested by me and I am not able to verify that the issue is actually fixed by backporting this patch without modification to an old release of mutt.

Reviewers, please be careful

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer
mutt: Backport patch for possible machine-in-the-middle response inje…
364f4d1 
…ction attack

This patch backports the patch which was applied in mutt release 1.14.4.
From the release notes:

    This is an important bug-fix release. It fixes a possible
    machine-in-the-middle response injection attack when using STARTTLS
    with IMAP, POP3, and SMTP.

This patch applies the fix unmodified.

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@matthiasbeyer matthiasbeyer changed the base branch from master to release-20.03 June 20, 2020 22:04
@ofborg ofborg bot requested review from rnhmjoj and the-kenny June 20, 2020 22:13
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Jun 20, 2020

I already patched mutt in 20.03 (PR #91072). I forgot to ping you, sorry.
I used the commit mentioned in the CVE text, yours is different, though: what's going on?

@matthiasbeyer
Copy link
Contributor Author

Huh, interesting! I used the patch Kevin (the mutt author) announced via the Mailinglist just yesterday. He wrote that there is no CVE number just yet! He wrote that yesterday but your commit is from two days ago... so I am confused now.

@Mic92
Copy link
Member

Mic92 commented Jun 22, 2020 •
edited

Seems like there is nothing to do here.

@Mic92 Mic92 closed this Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj Awaiting requested review from rnhmjoj

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthiasbeyer @rnhmjoj @Mic92