Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

broot: 0.15.1 -> 0.16.0 #91186

Merged
merged 1 commit into from Jun 21, 2020
Merged

broot: 0.15.1 -> 0.16.0 #91186

merged 1 commit into from Jun 21, 2020

Conversation

bbigras
Copy link
Contributor

@bbigras bbigras commented Jun 20, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/nix/store/158ffajs3rkghw733k53b08cx608mdmg-broot-0.15.1 37.5M
/nix/store/kgbsc8rzx1b6m74r7an4w36gr9rl9g0y-broot-0.16.0 37.5M

@ofborg ofborg bot requested a review from magnetophon June 20, 2020 19:41
@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

/marvin opt-in

@marvin-mk2 marvin-mk2 bot added the marvin label Jun 20, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Jun 20, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@bbigras
Copy link
Contributor Author

bbigras commented Jun 20, 2020

/status needs_review

@bhipple
Copy link
Contributor

bhipple commented Jun 21, 2020

Result of nixpkgs-review pr 91186 1

1 package built:
- broot

@bhipple bhipple merged commit e2e76d5 into NixOS:master Jun 21, 2020
@marvin-mk2 marvin-mk2 bot requested a review from timokau July 3, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@magnetophon magnetophon Awaiting requested review from magnetophon

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bbigras @bhipple