Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zfs-replication: document expected lz4 on host system #91146

Merged
merged 1 commit into from Aug 4, 2020
Merged

nixos/zfs-replication: document expected lz4 on host system #91146

merged 1 commit into from Aug 4, 2020

Conversation

tmplt
Copy link
Member

@tmplt tmplt commented Jun 20, 2020

Motivation for this change

As explained in #91122, pkgs.lz4 is expected to be installed on the host system. This PR adds a note in the module's documentation that lz4 is expected.

Closes #91122.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/198

@Mic92 Mic92 merged commit 1476c6f into NixOS:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elohmeier elohmeier elohmeier approved these changes

@dasJ dasJ dasJ approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nixos/zfs-replication: expected "âlz4câ" command missing
5 participants
@tmplt @nixos-discourse @elohmeier @dasJ @Mic92