Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unciv: init at 3.12.8 #91123

Merged
merged 1 commit into from Jan 22, 2021
Merged

unciv: init at 3.12.8 #91123

merged 1 commit into from Jan 22, 2021

Conversation

tex
Copy link
Contributor

@tex tex commented Jun 19, 2020

Motivation for this change

Fixes #90374

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member

teto commented Jun 21, 2020

I had a request to move a file upon launch but otherwise it launched. I had tried the game on smartphone (impressive IMO) but it's ugly on the computer.

.cache/nixpkgs-review/pr-91123 via ❄️  env (IMPURE) took 106ms 
(ins)➜ results/unciv/bin/unciv 
Packing textures - 4ms
mv: replace '/nix/store/yc96jxqx1fdrx51shs8pkrnvcdkr398d-hm_mimeapps.list', overriding mode 0444 (r--r--r--)? n
Loading game basics - 84ms
Loading translation file for English - 26ms
Loading percent complete of languages - 0ms
Loading translation file for English - 6ms
RNG seeded with 1592749152701
Natural Wonders for this game: [Krakatoa]
RNG seeded with 1592749158251
Natural Wonders for this game: [Rock of Gibraltar, Grand Mesa]
    Thread Autosave still running in UncivGame.dispose().
    Thread Thread-22 still running in UncivGame.dispose().

@tex
Copy link
Contributor Author

tex commented Jun 21, 2020

I didn't see the request to move file during my testing (nix-shell -p unciv).
Well, everyone has different taste, to me I run it in full screen in i3 and I like its GUI much more than freeciv...

@Lassulus
Copy link
Member

commit message should be: unciv: init at 3.9.4

pkgs/games/unciv/default.nix Outdated Show resolved Hide resolved
pkgs/games/unciv/default.nix Show resolved Hide resolved
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address comments, please.

@tex tex changed the title Unciv: 3.9.4 unciv: init at 3.9.4 Nov 1, 2020
@tex
Copy link
Contributor Author

tex commented Nov 1, 2020

Hmm, interesting. When I try to install it globally in my /etc/nixos/configuration.nix in which I have source to my local nixpkgs checkout then I get this error:

Packing textures - 110ms
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.lwjgl.LWJGLUtil$3 (file:/nix/store/y6ppqr188p5yfi1lbk31lscpg7jink9h-Unciv.jar) to method java.lang.ClassLoader.findLibrary(java.lang.String)
WARNING: Please consider reporting this to the maintainers of org.lwjgl.LWJGLUtil$3
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
libGL error: MESA-LOADER: failed to open i965 (search paths /run/opengl-driver/lib/dri)
libGL error: failed to load driver: i965
libGL error: MESA-LOADER: failed to open i965 (search paths /run/opengl-driver/lib/dri)
libGL error: failed to load driver: i965
libGL error: MESA-LOADER: failed to open swrast (search paths /run/opengl-driver/lib/dri)
libGL error: failed to load driver: swrast
Exception in thread "LWJGL Application" com.badlogic.gdx.utils.GdxRuntimeException: OpenGL is not supported by the video driver.
	at com.badlogic.gdx.backends.lwjgl.LwjglGraphics.createDisplayPixelFormat(LwjglGraphics.java:356)
	at com.badlogic.gdx.backends.lwjgl.LwjglGraphics.setupDisplay(LwjglGraphics.java:250)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication.mainLoop(LwjglApplication.java:146)
	at com.badlogic.gdx.backends.lwjgl.LwjglApplication$1.run(LwjglApplication.java:128)
Caused by: org.lwjgl.LWJGLException: X Error - disp: 0x7f6100022d80 serial: 221 error: BadValue (integer parameter out of range for operation) request_code: 152 minor_code: 24
	at org.lwjgl.opengl.LinuxDisplay.globalErrorHandler(LinuxDisplay.java:320)
	at org.lwjgl.opengl.LinuxDisplay.nDefineCursor(Native Method)
	at org.lwjgl.opengl.LinuxDisplay.updateCursor(LinuxDisplay.java:439)
	at org.lwjgl.opengl.LinuxDisplay.updatePointerGrab(LinuxDisplay.java:429)
	at org.lwjgl.opengl.LinuxDisplay.updateInputGrab(LinuxDisplay.java:574)
	at org.lwjgl.opengl.LinuxDisplay.destroyMouse(LinuxDisplay.java:991)
	at org.lwjgl.input.Mouse.destroy(Mouse.java:320)
	at org.lwjgl.opengl.Display.destroyWindow(Display.java:346)
	at org.lwjgl.opengl.Display.create(Display.java:859)
	at org.lwjgl.opengl.Display.create(Display.java:757)
	at com.badlogic.gdx.backends.lwjgl.LwjglGraphics.createDisplayPixelFormat(LwjglGraphics.java:348)
	... 3 more
milan@nixos> cat `which unciv`                                                                                                        ~
#! /nix/store/j206pskg2yzyla1cnfrb9kb5n5bfvjgm-bash-4.4-p23/bin/bash -e
export LD_LIBRARY_PATH='/nix/store/d5q09gyjg31mz6adg0px4r3xw183j42j-libpulseaudio-13.0/lib:/nix/store/97ka6sxxgickcwswh8vj8s027hzivzdq-libXxf86vm-1.1.4/lib'${LD_LIBRARY_PATH:+':'}$LD_LIBRARY_PATH
export PATH='/nix/store/4nk0r7vpcbfsc7hrpipxzl3ga08g007z-openjdk-14.0.2-ga/bin'${PATH:+':'}$PATH
exec "/nix/store/4nk0r7vpcbfsc7hrpipxzl3ga08g007z-openjdk-14.0.2-ga/bin/java"  -jar /nix/store/y6ppqr188p5yfi1lbk31lscpg7jink9h-Unciv.jar "$@"

But when I install it with nix-shell -p unciv from my overlay (which is exactly same as my local checkout of nixpkgs) then I get it running OK:

milan@nixos> nix-shell -p unciv                                                                                                       ~

[nix-shell:~]$ unciv
Packing textures - 91ms
Loading ruleset - 263ms
Loading ruleset - 107ms
Mod loaded successfully: Civilization 6 Mod

Loading percent complete of languages - 2ms
Natural Wonders for this game: [Barringer Crater]
    Thread Thread-8 still running in UncivGame.dispose().

[nix-shell:~]$ cat `which unciv`
#! /nix/store/k8p54jg8ipvnfz435mayf5bnqhw4qqap-bash-4.4-p23/bin/bash -e
export LD_LIBRARY_PATH='/nix/store/aammk7lmfhdwdbiw3mpfcb0g5l73i24g-libpulseaudio-13.0/lib:/nix/store/h103jxfhpqzxvlwbs8qb0lwfi3ifdsm1-libXxf86vm-1.1.4/lib'${LD_LIBRARY_PATH:+':'}$LD_LIBRARY_PATH
export PATH='/nix/store/3gpmm2lpl85g0ivlqpcrdp0k08xa25x8-openjdk-14.0.2-ga/bin'${PATH:+':'}$PATH
exec "/nix/store/3gpmm2lpl85g0ivlqpcrdp0k08xa25x8-openjdk-14.0.2-ga/bin/java"  -jar /nix/store/y6ppqr188p5yfi1lbk31lscpg7jink9h-Unciv.jar "$@"

Any idea what problem is it? I have for example steam enabed and installed in my global configuration.nix and it works.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 91123 run on x86_64-linux 1

1 package built:
  • unciv

@tex tex changed the title unciv: init at 3.9.4 unciv: init at 3.12.8 Jan 18, 2021
pkgs/games/unciv/default.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unciv
7 participants